[ https://issues.apache.org/jira/browse/THRIFT-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684265#comment-13684265 ]
Jens Geyer commented on THRIFT-2032: ------------------------------------ Patch [^THRIFT-2032-csharp-client-leaks-handles.patch ] does also fix a unnecessary double assignment to result2 in AcceptImpl(). > C# client leaks sockets/handles > ------------------------------- > > Key: THRIFT-2032 > URL: https://issues.apache.org/jira/browse/THRIFT-2032 > Project: Thrift > Issue Type: Bug > Components: C# - Compiler, C# - Library > Affects Versions: 0.9 > Reporter: Jens Geyer > Assignee: Jens Geyer > Fix For: 0.9.1 > > Attachments: THRIFT-2032-csharp-client-leaks-handles.patch > > > The C# client code does not correctly clean up the transport used, so the > programmer has to take care on his own about this. This may even lead to a > program hang in certain scenarios. Furthermore, the generated client should > support IDisposable. > Note that in contrast, the server side handles this automatically without any > explicit manual coding. > TODO: > * modify generated code to add IDisposable support > * modify TProtocol to add IDisposable support > * update the tutorial code accordingly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira