[ 
https://issues.apache.org/jira/browse/THRIFT-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Grochowski updated THRIFT-2039:
--------------------------------------

    Description: 
I've a problem with config.h: I compile thrift lib as a part of bigger project 
on both linux and windows. single config.h is not working for me. Also: my 
project does not contain config.h in root dir, so to make
{code}#include "config.h"{code} in thrift code I need to modify includes path 
for thrift sources.

I've come out with little workaround: I've added thrift-config.h file which 
"embeds" autotools config.h and predefined config.h for windows.
{code}
#ifdef _WIN32
# include <thrift/windows/config.h>
#else
# include <thrift/config.h>
#endif
{code}

and I've changed all occurrences of "config.h" to <thrift/thrift-config.h>

If I knew anything about autotools I'd also add prefixes to defines - like 
libevent (something like second patch from THRIFT-705) :)

  was:
I've a problem with config.h: I compile thrift lib as a part of bigger project 
on both linux and windows. single config.h is not working for me. Also: my 
project does not contain config.h in root dir, so to make
{code:cpp}#include "config.h"{code} in thrift code I need to modify includes 
path for thrift sources.

I've come out with little workaround: I've added thrift-config.h file which 
"embeds" autotools config.h and predefined config.h for windows.
{code:cpp}
#ifdef _WIN32
# include <thrift/windows/config.h>
#else
# include <thrift/config.h>
#endif
{code}

and I've changed all occurrences of "config.h" to <thrift/thrift-config.h>

If I knew anything about autotools I'd also add prefixes to defines - like 
libevent (something like second patch from THRIFT-705) :)

    
> config.h --> thrift-config.h
> ----------------------------
>
>                 Key: THRIFT-2039
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2039
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Konrad Grochowski
>
> I've a problem with config.h: I compile thrift lib as a part of bigger 
> project on both linux and windows. single config.h is not working for me. 
> Also: my project does not contain config.h in root dir, so to make
> {code}#include "config.h"{code} in thrift code I need to modify includes path 
> for thrift sources.
> I've come out with little workaround: I've added thrift-config.h file which 
> "embeds" autotools config.h and predefined config.h for windows.
> {code}
> #ifdef _WIN32
> # include <thrift/windows/config.h>
> #else
> # include <thrift/config.h>
> #endif
> {code}
> and I've changed all occurrences of "config.h" to <thrift/thrift-config.h>
> If I knew anything about autotools I'd also add prefixes to defines - like 
> libevent (something like second patch from THRIFT-705) :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to