[ 
https://issues.apache.org/jira/browse/THRIFT-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil Sałaś updated THRIFT-1947:
--------------------------------

    Attachment: 0001-Thrift-1947_v2.patch

* I don't get the first point. Could you point me where I should use a 
stringstream?
* Done, I've also updated the default constructor.
* It isn't possible to call one constructor from another. It has been added in 
C++0x.
* The enum generation was copied from the default constructor and was 
completely broken. I've fixed it at both places.
* Done.
* Second loop is copied from the default constructor.
* It was wrong. Fixed. 
* [Thrift-1946|https://issues.apache.org/jira/browse/THRIFT-1946]. I'd like to 
add proper support of issets in one place.
                
> C++ constructor with initializer list should be generated
> ---------------------------------------------------------
>
>                 Key: THRIFT-1947
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1947
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler
>            Reporter: Vitali Lovich
>            Assignee: Kamil Sałaś
>         Attachments: 0001-Thrift-1947.patch, 0001-Thrift-1947_v2.patch
>
>
> It would be really nice if the thrift constructor took in an initializer list 
> like the generated Java constructor does for non-optional fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to