[
https://issues.apache.org/jira/browse/THRIFT-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720873#comment-13720873
]
Khee Chin commented on THRIFT-2101:
-----------------------------------
My bad, when I tried to create a test-case for this issue, I did a git-pull and
verified the issue no longer exist with HEAD. It seems my previous thrift was
at a slightly older commit, 4f7ad2d98b22b367c7a4a25991cdf9a81647d3be.
Using git-bisect, it seems the fix was commited in
a7da48805c9fdcc4ad507272abd997ed1961d296 (Thu Jul 18 00:33:05 2013 +0200 by
Jens Geyer), written by you.
The thrift compiler now generates the safety variables in ttypes.go . However,
it seems to me that ttypes.go does not serve any purpose, is there any reason
why it is generated?
This issue can be closed.
> Go generator, unused imports causes compilation to fail
> -------------------------------------------------------
>
> Key: THRIFT-2101
> URL: https://issues.apache.org/jira/browse/THRIFT-2101
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
> Reporter: Khee Chin
> Attachments: types.patch
>
>
> After generating the go bindings for my idl file, on HEAD, compiling my go
> module fails with the error
> {quote}
> ERROR 2013/07/25 12:29:12 build.go:79: # test123/src/myapp/app/pymarissa
> gocode/src/test123/src/myapp/app/pymarissa/ttypes.go:7: imported and not
> used: "fmt"
> gocode/src/test123/src/myapp/app/pymarissa/ttypes.go:8: imported and not
> used: "git.apache.org/thrift.git/lib/go/thrift"
> Abort: Failed to build: Go Compilation Error (in
> gocode/src/test123/src/myapp/app/pymarissa/ttypes.go:7): imported and not
> used: "fmt"
> {quote}
> Since the imports are not used in ttypes.go, I've removed it (and the import
> protection) for f_types in the compiler phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
