[
https://issues.apache.org/jira/browse/THRIFT-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737284#comment-13737284
]
Jens Geyer edited comment on THRIFT-2109 at 8/12/13 8:14 PM:
-------------------------------------------------------------
There are some files missing. When I take them from the previous patch, my test
builds fine.
Next, it seems the tutorial server code lacks an error check:
{code}
cert, err := tls.LoadX509KeyPair("server.crt", "server.key")
{code}
This error seems not properly handled. Continuing the code leads then to an
"tls.Listen: no certificates in configuration" which is not wrong, but the real
problem in my case was "file Server.crt not found". You'll see the latter if
you {{return err}} instead of just ignoring it.
Please upgrade the patch file to contain __all__ the files again, then I'll
commit it.
was (Author: jensg):
There are some files missing. When I take them from the previous patch, my
test builds fine.
Next, it seems the tutorial server code lacks an error check:
{code}
cert, err := tls.LoadX509KeyPair("server.crt", "server.key")
{code}
This error seems not properly handled. Continuing the code leads then to an
"tls.Listen: no certificates in configuration" which is not wrong, but the real
problem in my case was "file Server.crt not found". You'll see the latter if
you {{return err}} instead of just ignoring it.
> Secure connections should be supported in Go
> --------------------------------------------
>
> Key: THRIFT-2109
> URL: https://issues.apache.org/jira/browse/THRIFT-2109
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Library
> Affects Versions: 0.9
> Reporter: Justin Judd
> Labels: Security
> Attachments: thrift-2109.patch
>
>
> Other languages, such as Java and C++ support SSLSockets for secure
> connections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
