[ 
https://issues.apache.org/jira/browse/THRIFT-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740462#comment-13740462
 ] 

Hudson commented on THRIFT-820:
-------------------------------

FAILURE: Integrated in Thrift #850 (See 
[https://builds.apache.org/job/Thrift/850/])
THRIFT-820 Remove readLength attribute from BinaryProtocol (carl: rev 
2ca9c2028593782621c8876817d8772aa5f46ac7)
* lib/delphi/src/Thrift.Protocol.pas
* lib/csharp/src/Protocol/TBinaryProtocol.cs
* lib/javame/src/org/apache/thrift/protocol/TBinaryProtocol.java
* lib/java/src/org/apache/thrift/protocol/TBinaryProtocol.java
* lib/go/thrift/binary_protocol.go
* lib/as3/src/org/apache/thrift/protocol/TBinaryProtocol.as

                
> The readLength attribute of TBinaryProtocol is used as an instance variable 
> and is decremented on each call of checkReadLength
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-820
>                 URL: https://issues.apache.org/jira/browse/THRIFT-820
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>    Affects Versions: 0.2, 0.3
>            Reporter: Nate McCall
>            Assignee: Carl Yeksigian
>             Fix For: 0.9.1
>
>         Attachments: 820.patch, 820-v2.patch, 
> tbinaryprotocol-length-check-patch-THRIFT-820.txt
>
>
> When coding towards readLength, I saw this more as a check on the message 
> length as it comes in. Perhaps its me, but I just dont see why this should 
> decrement giving the length header for each message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to