[
https://issues.apache.org/jira/browse/THRIFT-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746794#comment-13746794
]
Jens Geyer commented on THRIFT-1351:
------------------------------------
What about writeString()? Shouldn't that be connected in a similar way?
> Compiler does not care about binary strings
> -------------------------------------------
>
> Key: THRIFT-1351
> URL: https://issues.apache.org/jira/browse/THRIFT-1351
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Compiler
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: compiler, node, nodejs
> Fix For: 1.0
>
> Attachments: 0001-read-binary-strings-with-readBinary.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The node.js lib has support for binary strings, but the compiler does not
> check for it.
> It's quite easily fixed:
> https://github.com/onlinecity/thrift/commit/1d86faa2f44c7b8db80595375d6bd0b9b678c0ee
> With the fix node.js server implementations can operate on binary arguments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
