[ 
https://issues.apache.org/jira/browse/THRIFT-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766762#comment-13766762
 ] 

Hudson commented on THRIFT-2069:
--------------------------------

SUCCESS: Integrated in Thrift #897 (See 
[https://builds.apache.org/job/Thrift/897/])
THRIFT-2069: TPipeServer creates overlapped pipes, then uses synchronous I/O on 
them with TPipe (bencraig: rev b2501a71a79304fa27dfd6d2e55b75d8eacf0cef)
* lib/cpp/src/thrift/windows/OverlappedSubmissionThread.h
* lib/cpp/src/thrift/transport/TPipe.cpp
* lib/cpp/src/thrift/transport/TPipeServer.cpp
* lib/cpp/src/thrift/windows/OverlappedSubmissionThread.cpp
* lib/cpp/src/thrift/transport/TPipeServer.h
* lib/cpp/src/thrift/windows/Sync.h
* lib/cpp/src/thrift/transport/TPipe.h

                
> TPipeServer creates overlapped pipes, then uses synchronous I/O on them with 
> TPipe
> ----------------------------------------------------------------------------------
>
>                 Key: THRIFT-2069
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2069
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 1.0
>         Environment: Windows
>            Reporter: Ben Craig
>            Assignee: Ben Craig
>             Fix For: 1.0
>
>         Attachments: overlapped_pipes.patch
>
>
> The documentation for ReadFile states the following:
> A pointer to an OVERLAPPED structure is required if the hFile parameter was 
> opened with FILE_FLAG_OVERLAPPED, otherwise it can be NULL.
> http://msdn.microsoft.com/en-us/library/windows/desktop/aa365467%28v=vs.85%29.aspx
> In C++'s TPipeServer, we create a named pipe with FILE_FLAG_OVERLAPPED, then 
> create a TPipe with it.  TPipe then calls ReadFile without an overlapped 
> structure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to