[ 
https://issues.apache.org/jira/browse/THRIFT-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766899#comment-13766899
 ] 

Ben Craig commented on THRIFT-1944:
-----------------------------------

Minor: The patch needs to be updated, as it doesn't apply cleanly.  A "-1" 
changed to THRIFT_INVALID_SOCKET since you generated this patch.
Major: bzero isn't available on windows.  Some variant of memset may be 
appropriate.
                
> Binding to zero port
> --------------------
>
>                 Key: THRIFT-1944
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1944
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: All platforms
>            Reporter: Akshat Aranya
>              Labels: bind
>             Fix For: 1.0
>
>         Attachments: patch-THRIFT-1944-java.patch, patch-THRIFT-1944.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This patch builds upon a previously submitted patch that was not accepted 
> (THRIFT-966).  The purpose of this patch is to allow TServerSocket to bind to 
> port zero, that is, have the server socket be assigned a port by the OS.  
> This patch provides a way to query the port after the socket has been bound 
> and determine the OS assigned port

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to