[
https://issues.apache.org/jira/browse/THRIFT-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768687#comment-13768687
]
Jens Geyer commented on THRIFT-1755:
------------------------------------
The [first patch|^thrift-1755.patch], altough quite clever, does not really
address the core issue, rather it tries to cure the symptom somehow. In
particular, it relies on internal behaviour of clean_up_doctext(), which may be
changed in the future.
I therefore propose [this patch|^THRIFT-1755_comment_parsing_bug.patch], which
combines the former patch with a fix to the wrong assumption in
clean_up_doctext().
> Comment parsing bug
> -------------------
>
> Key: THRIFT-1755
> URL: https://issues.apache.org/jira/browse/THRIFT-1755
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler, Java - Compiler
> Affects Versions: 0.9
> Environment: Windows 7
> Reporter: Bud Bundy
> Priority: Minor
> Labels: compilation
> Attachments: THRIFT-1755_comment_parsing_bug.patch, thrift-1755.patch
>
>
> thrift-0.9.0.exe crashes when trying to parse a thrift description file with
> a particular style of comment.
> The crash message is:
> {code}
> Assertion failed: docstring.length() <= strlen(doctext), file src/main.cc,
> line 548
> This application has requested the Runtime to terminate it in an unusual way.
> Please contact the application's support team for more information.
> {code}
> Reproducible with the following definitions file:
> {code}
> service myservice
> {
> /**SomeTextHere*/
> }
> {code}
> Note that if you put a space like so /**SomeTextHere */, it compiles.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
