[ https://issues.apache.org/jira/browse/THRIFT-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771851#comment-13771851 ]
Ben Craig commented on THRIFT-2198: ----------------------------------- First off, yes, it is absolutely an issue, and it should be fixed. It's been broken a long time. Prior to 0.9.1 (I think), the code was spelled "close()", but a force include #define'd close() to closesocket() on Windows. While getting rid of the force include, I mechanically changed every instance of close() with THRIFT_CLOSESOCKET(). So if you have a patch for the issue, I'll gladly review it. > THRIFT_CLOSESOCKET on win32 platforms is wrong defined for TFileProtocol > ------------------------------------------------------------------------ > > Key: THRIFT-2198 > URL: https://issues.apache.org/jira/browse/THRIFT-2198 > Project: Thrift > Issue Type: Bug > Affects Versions: 0.9.1 > Reporter: Vladimir Petrov > Priority: Trivial > > During preprocessing TFileProtocol.cpp _THRIFT_CLOSESOCKET_ is replaced with > _closesocket_, not _close_ function, 1) it's wrong (we have no deals with > sockets there) 2)process run-time warning 3) don't close an opened file -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira