[
https://issues.apache.org/jira/browse/THRIFT-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773782#comment-13773782
]
Jens Geyer commented on THRIFT-2200:
------------------------------------
Hi C++ folks,
would be great if someone could spend some time to review that soon. Most
changes affect C++, but all languages will profit from an overall more
performant Thrift Compiler due to lazy FP generation.
The patch can very likely be combined without much hassle with Randy's
THRIFT-2199 proposal (Randy, please correct me if I'm wrong).
Thanks in advance
> nested structs cause generate_fingerprint() to slow down at excessive CPU load
> ------------------------------------------------------------------------------
>
> Key: THRIFT-2200
> URL: https://issues.apache.org/jira/browse/THRIFT-2200
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Fix For: 0.9.2
>
> Attachments: THRIFT-2200_slow_fingerprints.patch
>
>
> The file http://pastebin.com/H5Uj74aW contains a number of nested structs
> definitions. These highly recursive structs (over 8 levels in this case)
> cause the get_fingerprint_material() method to loop over minutes.
> Thanks to Niclas who prepared the pastebin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
