[
https://issues.apache.org/jira/browse/THRIFT-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780051#comment-13780051
]
Alex Loukissas commented on THRIFT-2139:
----------------------------------------
Great thanks!
Btw, the patch was not from the lib directory, rather it was generated from the
root with --no-prefix option. I usually prefer this so that I patch with -p0
from the root directory.
The warning you mention is fixable, with conditional compilation of either of
the two thread factory sources. I know how to do this, just let me know what's
the preferred way of dealing with it (in my projects I rely on an env variable
for this conditional).
> MSVC 2012 Error - Cannot compile due to BoostThreadFactory
> ----------------------------------------------------------
>
> Key: THRIFT-2139
> URL: https://issues.apache.org/jira/browse/THRIFT-2139
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.1
> Environment: MSVC 2012 x64
> Reporter: Chris Stylianou
> Priority: Blocker
> Labels: c++, msvc, thrift
> Fix For: 0.9.2
>
> Attachments: THRIFT-2139.patch
>
>
> Errors given are:
> bq.error C2664: 'std::thread::id::id(const std::thread &)' : cannot convert
> parameter 1 from 'boost::thread::id' to 'const std::thread &'
> C:\Users\chris\Desktop\workspace\build\thrift\thrift-0.9.1\lib\cpp\src\thrift\concurrency\BoostThreadFactory.cpp
> 101 1 libthrift
> bq.error C2664: 'std::thread::id::id(const std::thread &)' : cannot convert
> parameter 1 from 'boost::thread::id' to 'const std::thread &'
> C:\Users\chris\Desktop\workspace\build\thrift\thrift-0.9.1\lib\cpp\src\thrift\concurrency\BoostThreadFactory.cpp
> 165 1 libthrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
