[ https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789674#comment-13789674 ]
Jens Geyer commented on THRIFT-2031: ------------------------------------ Just a question: {code}setKeepAlive(false){code} does not really clear the SO_KEEPALIVE flag, it just sets the member variable keepAlive_ and then returns doing noting else. By Intention? {code} void TSocket::setKeepAlive(bool keepAlive) { keepAlive_ = keepAlive; if (socket_ == -1 || keepAlive_ == false) { return; } {code} > Make SO_KEEPALIVE configurable for C++ lib > ------------------------------------------ > > Key: THRIFT-2031 > URL: https://issues.apache.org/jira/browse/THRIFT-2031 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Affects Versions: 0.9 > Environment: All > Reporter: Ben Craig > Assignee: Ben Craig > Fix For: 1.0 > > Attachments: keep_alive2.patch > > > It's a socket option that we haven't made configurable yet, and sometimes you > need it. -- This message was sent by Atlassian JIRA (v6.1#6144)