[ https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Craig updated THRIFT-2045: ------------------------------ Attachment: windows_compiler_port.patch Once more... with feeling. Using "config.h" and guarding it with HAVE_CONFIG_H was a mistake. That ends up changing behavior for POSIX builds and mingw builds, which wasn't intended. I'm now doing basically the same thing, but explicitly pulling in "windows/config.h", and guarding the include with _MSC_VER. This should only affect native builds with visual studio, and not mingw cross compiles. This sucks for people using the non-msvc native compilers, but they are probably used to pain by now. > C++ compiler warning and build cleanup > -------------------------------------- > > Key: THRIFT-2045 > URL: https://issues.apache.org/jira/browse/THRIFT-2045 > Project: Thrift > Issue Type: Bug > Components: C++ - Compiler, Go - Compiler, Python - Compiler > Affects Versions: 0.9 > Reporter: Ben Craig > Assignee: Ben Craig > Priority: Minor > Fix For: 1.0 > > Attachments: windows_compiler_port.patch > > > Fixing assorted warnings and minor issues in the compiler: > * Fixing a warning in C++ generated code concerning an unused catch argument > in oneway functions. > * Generally using _WIN32 instead of MINGW as a test for Windows. Building > the compiler should no longer require the build process to define MINGW. > * Providing THRIFT_PATH_MAX for the portable portions of the code. This > evaluates to either MAX_PATH or PATH_MAX, depending on whichever one is > available. > * Shrank "value" field of t_field_id in order to clean up warnings. I > suspect that thrift doesn't support more than 2 billion fields anyway. > * Squelching various warnings in code, instead of in the build process. FOr > example, "unreferenced label", "switch statement contains 'default' but no > 'case' labels", and "bool conversion performance warnings" are all disabled > via pragma now, at appropriate locations. -- This message was sent by Atlassian JIRA (v6.1#6144)