[ 
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791847#comment-13791847
 ] 

Henrique Mendonça commented on THRIFT-2205:
-------------------------------------------

Hi Randy,
Sorry for the delay, I've been really busy recently. Would you be able to 
create a base class for this test code so that we can use it on the three test 
variants?
We are repeating the same code again and again here...
I was thinking we could use node-http-proxy and connect to handle the static 
server but your patch works, and that's what we need.
Thanks again!


> Node.js Test Server to support test.js JavaScript Browser test and sundry 
> fixes
> -------------------------------------------------------------------------------
>
>                 Key: THRIFT-2205
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2205
>             Project: Thrift
>          Issue Type: Improvement
>          Components: JavaScript - Library, Node.js - Library
>    Affects Versions: 1.0
>         Environment: All
>            Reporter: Randy Abernethy
>            Assignee: Randy Abernethy
>            Priority: Minor
>              Labels: node, nodejs
>         Attachments: 
> 0003-node-JSON-protocol-fixes-and-test-server-to-support-.patch
>
>
> Adds lib/nodejs/test/testsvr.js 
> This server depends on ThriftTest[.js] and runs clean with test.js in the 
> browser.
> Also in this patch:
> Repairs some shortfall in the Node JSON Protocol and transport. Fixes 
> overflow on Javascript I64 tests. Improves static_server header output.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to