Hi Andrew First I want to thank you for taking the time to contribute, your help is greatly appreciated.
For pull requests from Github, we (Apache Thrift) do not accept them because there is no mechanism in place currently that grants use of that code to the ASF for that pull request. Also Github is only a mirror of our official code repository, so we can not accept, merge and close the pull request via Github. Also only a limited number of people are part of the Apache organization on Github which is why we have 60+ open pull requests currently. We have kept the process the same for how we accept contributions from when we incubated to current. There are discussions and work underway in @infra to help with closing and accepting pull requests from Github, but currently we take all contributions via jira tickets and attachments. The pull requests you issue from Github do not add noise to the dev@ list as they are moderated out and only the moderators will see the actual pull request message come through. If it helps you better track your contributions please continue to do so. -Jake On Tue, Oct 22, 2013 at 1:09 PM, Andrew Gaul <g...@apache.org> wrote: > Ben, I have opened JIRA issues with attachments for all of my patches. > I open the in GitHub pull request to allow for review comments and for > my own tracking purposes. If the PR adds too much noise I will > discontinue this practice. Let me know how to best contribute. > > (Inaccurate to say that Thrift can't accept pull requests. Other Apache > projects including jclouds which I contribute to use JIRA for issue > tracking and GitHub for code. Most code has a JIRA issue except for > smaller, cleanup commits.) > > On Tue, Oct 22, 2013 at 08:47:53AM -0500, Ben Craig wrote: > > Thanks you for your interest Andrew. Unfortunately, we can't currently > > accept git pull requests. We only accept patches attached to JIRA > > tickets. For more information on how to get changes into Thrift, see the > > following page: > > http://thrift.apache.org/docs/HowToContribute/ > > > > andrewgaul <g...@git.apache.org> wrote on 10/22/2013 01:04:03 AM: > > > > > From: andrewgaul <g...@git.apache.org> > > > To: dev@thrift.apache.org, > > > Date: 10/22/2013 08:22 AM > > > Subject: thrift pull request: Defensively copy binary fields > > (THRIFT-2233) > > > > > > GitHub user andrewgaul opened a pull request: > > > > > > https://github.com/apache/thrift/pull/60 > > > > > > Defensively copy binary fields (THRIFT-2233) > > > > > > This ensures that one consumer of a ByteBuffer does not interfere > > with > > > another, e.g., > > > > > > MyStruct myStruct = ...; > > > byte[] array = new byte[myStruct.bufferForValue().capacity()]; > > > someStruct.bufferForValue().get(array); > > > someStruct.bufferForValue().get(array); // previously, NPE > > > > > > You can merge this pull request into a Git repository by running: > > > > > > $ git pull https://github.com/maginatics/thrift defensive-copy > > > > > > Alternatively you can review and apply these changes as the patch at: > > > > > > https://github.com/apache/thrift/pull/60.patch > > > > > > ---- > > > commit 5f7545b1dcd0d94724bc41cfb41bef0d7d4c869d > > > Author: Andrew Gaul <g...@maginatics.com> > > > Date: 2013-10-22T00:38:15Z > > > > > > Defensively copy binary fields (THRIFT-2233) > > > > > > This ensures that one consumer of a ByteBuffer does not interfere > > with > > > another, e.g., > > > > > > MyStruct myStruct = ...; > > > byte[] array = new byte[myStruct.bufferForValue().capacity()]; > > > someStruct.bufferForValue().get(array); > > > someStruct.bufferForValue().get(array); // previously, NPE > > > > > > ---- > > > > > -- > Andrew Gaul > http://gaul.org/ >
