[ 
https://issues.apache.org/jira/browse/THRIFT-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807101#comment-13807101
 ] 

Ben Craig commented on THRIFT-2242:
-----------------------------------

If we were to make changes that broke source compatibility, my preference would 
be to do more than just make minor tweaks like boost:: -> std:: and map -> 
unordered_map.  I would prefer such a change to be treated as a new language 
(cpp11 / cpp14), and take that opportunity to clear up a lot of the warts in 
the library.  I mentioned as much in the comments to THRIFT-1753.

That being said, I still see that as being lower priority than a lot of other 
features, including documentation.

One thing that can be done to increase the priority would be to supply a patch. 
 If the patch doesn't break existing C++03 clients, while also providing decent 
test coverage for C++11 use cases, then it is more likely to get accepted.

> Generate C++11 code
> -------------------
>
>                 Key: THRIFT-2242
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2242
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.1
>            Reporter: Vitali Lovich
>
> unordered_map instead of map, unordered_set instead of set, noexcept instead 
> of throw() (unless the exact semantics of throw() are needed which seems 
> unlikely).
> It should use the shared_ptr implementation that the library is configured 
> with.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to