[ 
https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812284#comment-13812284
 ] 

Hudson commented on THRIFT-1815:
--------------------------------

FAILURE: Integrated in Thrift #932 (See 
[https://builds.apache.org/job/Thrift/932/])
THRIFT-1815 Code generators line buffer output - Go compiler (jensg: rev 
53078be3ee94d557a81e162b727bfe643c3e9dd8)
* compiler/cpp/src/generate/t_go_generator.cc


> Code generators line buffer output
> ----------------------------------
>
>                 Key: THRIFT-1815
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1815
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General)
>    Affects Versions: 0.9
>            Reporter: Andrew Gaul
>              Labels: performance
>             Fix For: 0.9.1, 0.9.2
>
>         Attachments: THRIFT-1815-endl-patch-for-go.patch, 
> thrift-1815-compiler-line-buffering.patch
>
>
> This results in slow performance on FUSE- and network-based filesystems, 
> e.g., eCryptfs.  std::ostream << std::endl emits a newline and flushes 
> buffers to the kernel[1], yielding excessive system calls.  Instead, emit 
> "\n" which does the equivalent without the flush[2].  The attached patch 
> accomplishes this while minimizing code churn by removing "using namespace 
> std" and introducing a static variable endl.
> [1] http://www.cplusplus.com/reference/ios/endl/
> [2] 
> http://stackoverflow.com/questions/5492380/what-is-the-c-iostream-endl-fiasco



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to