[ 
https://issues.apache.org/jira/browse/THRIFT-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815741#comment-13815741
 ] 

Martin Vogt commented on THRIFT-2255:
-------------------------------------

Hello David,

maybe you take a look at this patch:

https://issues.apache.org/jira/browse/THRIFT-1712

Your approach to always/unconditionally use a base class 
is ok too. But I think that the base class should have
some support from the generator.
Like the ascii_fingerprint, and a copy implementation.
The ascii_fingerprint is very usefully to identify the class,
for runtime casting.

<hint>
My patch is waiting for some votes since a year or so.
</hint>

regards,

Martin


> add Parent Class for generated Struct class
> -------------------------------------------
>
>                 Key: THRIFT-2255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: C++ - Compiler
>    Affects Versions: 0.8
>         Environment: Linux and Windows
>            Reporter: david han
>              Labels: patch
>             Fix For: 0.8
>
>         Attachments: patch.tar.gz
>
>
> Cpp generated Class of struct dosn't have a parent Class, this will cause the 
> Program hold the Object must be using The instance class direct.
> The parent class may be helper full in for program to process manay type 
> Struct batch.
> I hope the New version of Thrift implement it.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to