[ https://issues.apache.org/jira/browse/THRIFT-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821410#comment-13821410 ]
Andrew Pennebaker edited comment on THRIFT-2218 at 11/13/13 3:23 PM: --------------------------------------------------------------------- +1 Once TSerializer and TDeserializer are threadsafe, could libthrift provide static versions of them? I never understood why I had to instantiate objects for them, just to use their serializer/deserialize methods. was (Author: apennebaker42six): +1 Functional programming style plz. > Make java TSerializer and TDeserializer thread safe > --------------------------------------------------- > > Key: THRIFT-2218 > URL: https://issues.apache.org/jira/browse/THRIFT-2218 > Project: Thrift > Issue Type: Improvement > Components: Java - Library > Reporter: Alex Levenson > Assignee: Jake Farrell > Attachments: TSerDe-thread-safe.diff > > > They currently are not thread safe, though it seems that many people assume > incorrectly that they are. > This patch puts the shared mutable state used by TSerializer / TDeserializer > in a ThreadLocal object so that it is safe to share instances of TSerializer > / TDeserializer across threads. > I've attached the patch, and you can view it in github here as well: > https://github.com/isnotinvain/thrift/compare/TSerDe-thread-safe -- This message was sent by Atlassian JIRA (v6.1#6144)