[
https://issues.apache.org/jira/browse/THRIFT-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832007#comment-13832007
]
Niraj Tolia commented on THRIFT-2272:
-------------------------------------
[~roger.meier] Those patches seem to belong to me and are from a long time ago.
They are neither the correct fix and will not apply to master either. As I
mentioned
[elsewhere|https://issues.apache.org/jira/browse/THRIFT-1643?focusedCommentId=13806973&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13806973],
a separate and new fix is needed. I can probably contribute that but I am
currently buried under other work and it will take some time.
> CLONE - Denial of Service attack in TBinaryProtocol.readString
> --------------------------------------------------------------
>
> Key: THRIFT-2272
> URL: https://issues.apache.org/jira/browse/THRIFT-2272
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.6.1, 0.8
> Environment: All
> Reporter: Valentin Mayamsin
> Assignee: Niraj Tolia
> Priority: Critical
> Labels: security
> Fix For: 0.9
>
> Attachments:
> 0001-Add-test-for-TCompactProtocol-OOM-Denial-of-Service.patch,
> 0001-Address-denial-of-service-in-TCompactProtocol.patch,
> 0002-Add-test-for-TBinaryProtocol-OOM-Denial-of-Service.patch,
> 0003-Cleanup-length-checks-in-TCompactProtocol.patch, Attack.java, Foo.thrift
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> In readString, if the string field's size is greater than the number of bytes
> remaining in the byte array to deserialize, libthrift will happily allocate a
> byte array of that size in readStringBody, filling the heap.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
