[ https://issues.apache.org/jira/browse/THRIFT-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838913#comment-13838913 ]
Ben Craig commented on THRIFT-2258: ----------------------------------- I apologize. I've been swamped at work, so I haven't had a chance to look at this in depth. I have not tested it yet, but in principal, the patch looks fine. The one thing I'm not sure about is whether the presence of the SSLv23_method and TLSv1_2_method will force an upgrade of the build time openSSL or not. Those may need to hide behind some kind of compile time OpenSSL version check. > Add TLS v1.1/1.2 support to TSSLSocket.cpp > ------------------------------------------ > > Key: THRIFT-2258 > URL: https://issues.apache.org/jira/browse/THRIFT-2258 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Affects Versions: 0.9.1 > Reporter: Chris Stylianou > Assignee: Ben Craig > Labels: c++, ssl, thrift, tls > Attachments: thrift-2258.patch > > > At the moment TSSLSocket.cpp hard-codes the SSL/TLS protocol to TLSv1.0, > which does not allow any other protocols to be used instead (SSL v3, TLS > v1.0, v1.1, v1.2, *ignores SSLv2 as horribly insecure*). > Could a method be provided on the TSSLSocketFactory to set the required > protocol (like how there is already a cipher() function available), so that > when SSL_CTX_new, it is called with the specified SSL/TLS protocol. > Sorry to label this as a bug, but being unable to select the highest availabe > security protocol for communication is a bug in my eyes. -- This message was sent by Atlassian JIRA (v6.1#6144)