Hey Henrique, Thanks for the note and I think you are right. We could use two things: 1. Semver git tags 2. Git visible js/dist directory (where the concat and min files are generated)
We could use js/src, but I think that will be troublesome in the future as more sources are added (web socket transports, additional protocols etc.). Ultimately we should also shift tests to use the js/dist directory (testing the built out concat and min files, just like the tests in Java or C++ use the build product for tests). That is all forward looking though, so if js/src is the only thing that makes sense right now I think it is still worth doing. Bower is the npm of front end dev and I think Apache Thrift deserves an official presence there. -Randy On Sun, Feb 2, 2014 at 4:43 AM, Henrique Mendonça <henri...@apache.org>wrote: > Hi Randy, > > I think you can test it with your own fork like: > https://github.com/henrique/thrift/blob/master/bower.json > bower install https://github.com/henrique/thrift.git > > I don't really use bower so I am not sure if this reference to /lib/js/src > works. However, if it does we would only need to have standard semver tags > the official git repo. Our current tags from 0.6 always start with > "thrift-" so bower only recognizes 0.5.0 on the current repo. We'd need to > add new tags like in http://semver.org/ : "M.M.P" or "vM.M.P" > > @Jake&Roger: why did we start appending thrift- to our tags after 0.5? > > Cheers, > Henrique > > > On 1 February 2014 22:28, Randy Abernethy (JIRA) <j...@apache.org> wrote: > > > > > [ > > > https://issues.apache.org/jira/browse/THRIFT-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888743#comment-13888743 > ] > > > > Randy Abernethy commented on THRIFT-2190: > > ----------------------------------------- > > > > Someone with the appropriate authority needs to run the registration. > Also > > the library posted should be the output of the JS grunt build (in > js/dist). > > This way as the js/src grows and separate files manifest the js/dist will > > continue to present a single concatenated minified gzipped thrift.js > > archive for distribution. This will require the js/dist to appear at some > > git end point. > > > > Per Bower: > > To register a new package: > > There must be a valid manifest JSON in the current working > directory. > > Your package should use semver Git tags. > > Your package must be available at a Git endpoint (e.g., GitHub); > > remember to push your Git tags! > > Then use the following command: > > bower register <my-package-name> <git-endpoint> > > The Bower registry does not have authentication or user management at > this > > point in time. It's on a first come, first served basis. Think of it > like a > > URL shortener. Now anyone can run bower install <my-package-name>, and > get > > your library installed. > > > > There is no direct way to unregister a package yet. For now, you can > > request a package be unregistered. > > > > > Add the JavaScript thrift.js lib to the Bower registry > > > ------------------------------------------------------ > > > > > > Key: THRIFT-2190 > > > URL: https://issues.apache.org/jira/browse/THRIFT-2190 > > > Project: Thrift > > > Issue Type: Wish > > > Components: JavaScript - Library > > > Affects Versions: 1.0 > > > Reporter: Randy Abernethy > > > Assignee: Randy Abernethy > > > Priority: Minor > > > Labels: Bower,, Grunt,, package.json > > > Fix For: 0.9.2 > > > > > > Attachments: > > 0001-Setup-grunt-and-package.json-project-for-browser-thr.patch > > > > > > > > > Grunt/Bower/Yeoman appear to have the wind at their back. Would be > great > > for front end JavaScript developers to be able to bower install thrift. > > > http://bower.io/ > > > This patch adds a grunt project, jsdoc, jshint, concat, minification > and > > qunit test runner. > > > > > > > > -- > > This message was sent by Atlassian JIRA > > (v6.1.5#6160) > > >
