[ 
https://issues.apache.org/jira/browse/THRIFT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896074#comment-13896074
 ] 

Randy Abernethy commented on THRIFT-2325:
-----------------------------------------

I think most commonly bower install pulls in just js distributable libs. So the 
most text book answer would be to run the grunt build in lib/js to produce the 
lib/js/dist directory (with the concatenated thrift.js and a minified 
thrift.min.js) and then put the Bower json there. That means the output of the 
build needs to be on github or somewhere else git accessible for bower.

The other option is to bower the entire lib/js dir so folks can run local grunt 
builds and have access to the examples and tests. The more I think about it the 
more I think that the bower install will be used mostly by front end devs who 
have thrift as a dependency. They don't really need or want anything but the 
built libs in lib/js/dist.

Long story short I think we should get rid of lib/js/test/sec and use the 
test/keys stuff for the JavaScript SSL tests and I think we should have bower 
install pull only the files in the  lib/js/dist  output directory . 

> SSL test certificates
> ---------------------
>
>                 Key: THRIFT-2325
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2325
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Test Suite
>            Reporter: Roger Meier
>            Assignee: Roger Meier
>             Fix For: 0.9.2, 1.0
>
>         Attachments: 0001-THRIFT-2325-SSL-test-certificates.patch
>
>
> We need common ssl certificates within test/ or test/ssl/
> to simplify cross language tests.
> today we have this:
> ./test/py/test_cert.pem
> some test code uses:
> * trusted-ca-certificate.pem
> * server-certificate.pem
> * server-private-key.pem



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to