[ 
https://issues.apache.org/jira/browse/THRIFT-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910005#comment-13910005
 ] 

Jake Farrell commented on THRIFT-2305:
--------------------------------------

[~jensg] see no issues with this, commit if you are happy with the updates

> TFramedTransport empty constructor should probably be private
> -------------------------------------------------------------
>
>                 Key: THRIFT-2305
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2305
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C# - Library
>            Reporter: Alex Ausch
>            Priority: Trivial
>             Fix For: 0.9.2
>
>         Attachments: TFramedTransport_cs_refactor.patch, 
> THRIFT-2305-misc-Transport_refactorings_v2.patch
>
>
> A TFramedTransport without an inner transport doesn't make sense.
> Therefore, the empty constructor should probably not be public - most likely 
> private (possibly protected?).
> Attaching patch file, including some formatting corrections.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to