Hi Alex, > I would love to add a test, unfortunately I'm completely lost in thrift's > testing architecture.
> Could you please point me to any thrift --gen go related tests? At minimum, I > would > need to run -gen go on certain thrift file then run go compiler to make sure > it compiles. There are several *_test-go files in /lib/go/thrift which you can run by “go test” as usual, or via “make check”. In addition to that, I have some other test cases at my machine, which are not part of the Thrift repo for different reasons. Regarding THRIFT-2381, adding a test case to /lib/go/thrift would be sufficient, IMHO. Thanks again for your work on this, JensG From: Aleksey Pesternikov Sent: Thursday, March 6, 2014 5:50 PM To: Jens Geyer Subject: Re: https://issues.apache.org/jira/browse/THRIFT-2384 Jens, Thank you for committing the fix. I would love to add a test, unfortunately I'm completely lost in thrift's testing architecture. Could you please point me to any thrift --gen go related tests? At minimum, I would need to run -gen go on certain thrift file then run go compiler to make sure it compiles. On Fri, Feb 28, 2014 at 10:24 AM, Jens Geyer <jensge...@hotmail.com> wrote: Hi Alex, thanks for pointing this out. I have seen this with THRIFT-2381 but somehow believed that binary did not work at all for keys. Do you see any chance to provide a test case, so it doesn’t happen again? Thanks, JensG From: Aleksey Pesternikov Sent: Friday, February 28, 2014 7:07 AM To: jensge...@hotmail.com Subject: https://issues.apache.org/jira/browse/THRIFT-2384 Hi Jens, I just updated to the latest dev and found that it generates broken code for binary maps again, fix is attached to the jira ticket, please take a look
