Hi Randy, I agree it doesn't make sense to deploy tests that don't work. Then, only the source will do it.
What about another package thrift-dev for test+lib/nodejs+compiler? Although we can get everything directly from the source, NPM handles versioning quite nicely. On 15 March 2014 20:41, Randy Abernethy <randy.aberne...@gmail.com> wrote: > Hello All, > > Presently NPM deploys the entire thrift/lib/nodejs directory. This includes > thrift/lib/nodejs/test and thrift/lib/nodejs/example in particular. Though > there are several examples of other projects distributing full project > trees with a lib, my sense is that people use npm to deploy operational > libraries, expecting/needing only the production code to be copied. Those > interested in library builds/tests/examples/etc. will more often clone the > git repo. > > There are some technical complications with deploying Apache Thrift node.js > libs with the test directory related to the server key used for ssl > testing. A copy of the server key must be distributed for the tests to > succeed, rather than linking them to the thirft/test/keys source. Other > issues such as this may be extant. > > Would it not be better to have npm deploy only > thrift/lib/nodejs/lib/thrift. This would create just a thrift directory > under the npm node_modules path causing node to pickup the index.js > directly? > > Sorry if this has already been discussed, > Randy >
