[ 
https://issues.apache.org/jira/browse/THRIFT-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945637#comment-13945637
 ] 

Jens Geyer edited comment on THRIFT-2421 at 3/24/14 8:33 PM:
-------------------------------------------------------------

Some remarks:

(1) What is the following code for, in {{generate_forward_declaration()}}? It 
is never used ...

{code}
struct TypeInfo {
  uint64_t id;
  std::string name;
};
{code}

(2) While quite clever, I'm afraid that just declaring unresolved types as a 
{{typedef}} seems a bit too simple. We need at least an additional flag to be 
able to distinguish these references from real typedefs. I can provide a patch, 
if necessary.


was (Author: jensg):
What is the following code for, in generate_forward_declaration()? It is never 
used ...

{code}
struct TypeInfo {
  uint64_t id;
  std::string name;
};
{code}


> Tree/Recursive struct support in thrift
> ---------------------------------------
>
>                 Key: THRIFT-2421
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2421
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: C++ - Library
>            Reporter: Jake Farrell
>            Assignee: Jake Farrell
>             Fix For: 0.9.2
>
>         Attachments: 84.patch
>
>
> Patches to implement tree/list/co-recursive structures in thrift
> https://github.com/apache/thrift/pull/84



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to