[
https://issues.apache.org/jira/browse/THRIFT-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960037#comment-13960037
]
Randy Abernethy commented on THRIFT-1743:
-----------------------------------------
Hey All,
Sounds like we have a workable compromise which will make thrift easy to
install in PHP and keep the thrift master root clean. The fact that
composer.json needs to be in the repo root has inspired the creation of a
thrift-php repo for releases. This is the same challenge we have with
bower.json in JavaScript (there will be a thrift-js repo for browser side
JavaScript releases). Each of these repos will be updated with every thrift
release allowing any version up to the current release to be installed.
Let me know if the process and code below sounds right to everyone:
*When 0.9.2 is released we will:*
{code}
1. git clone thrift-php
2. cd thrift-php
3. cp ../thrift/lib/php/{*, composer.json} .
4. git add -A
5. git commit -m "thrift-0.9.2"
{code}
All of the PHP eco system installers and dependency managers will point to:
https://github.com/apache/thrift-php
The composer.json will be checked in to the master in thrift/lib/php. The
composer.json contents will need to be relative to / so that it works when
copied to thrift-php. The following is the proposed composer.json contents:
{code}
{
"name": "apache/thrift",
"description": "Apache Thrift RPC system",
"homepage": "http://thrift.apache.org/";,
"type": "library",
"license": "Apache-2.0",
"authors": [
{
"name": "Apache Thrift Developers",
"email": "dev@thrift.apache.org",
"homepage": "http://thrift.apache.org";
}
],
"support": {
"email": "dev@thrift.apache.org",
"issues": "https://issues.apache.org/jira/browse/THRIFT";
},
"require": {
"php": ">=5.3.0"
},
"autoload": {
"psr-0": {"Thrift": "src/"}
},
"target-dir": ".",
"minimum-stability": "dev",
"extra": {
"branch-alias": {
"dev-master": "0.9.x-dev"
}
}
}
{code}
Please comment if you see problems with this process!
Thanks,
Randy
> Add composer.json for new Symfony 2.1 Dependency Manager
> --------------------------------------------------------
>
> Key: THRIFT-1743
> URL: https://issues.apache.org/jira/browse/THRIFT-1743
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.9, 1.0
> Reporter: Xavier HAUSHERR
> Assignee: Randy Abernethy
> Fix For: 0.9.2
>
> Attachments: composer.json, composer.master.json
>
>
> In order to use the new Symfony 2.1 Dependency Manager
> (http://getcomposer.org/), we have to add on root of Github project a file
> called composer.json with Composer configuration.
> This file must place in "/" in trunk and in 0.9x branch if possible.
> Is it possible to add this file ?
> Best regards.
> Xavier HAUSHERR
--
This message was sent by Atlassian JIRA
(v6.2#6252)
