Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/92#issuecomment-39585543
Hey @djwatson, thanks for another patch, really appreciate your
contributions back to Apache Thrift. looking at it quickly config check are
good, compiler looks good, files added to dist (thanks, this often gets missed)
and lib with test cases look good, if you could address the following I think
this can get merged in
- Facebook license headers on some of the files, needs to be replaced with
the Apache license version 2.0 headers
- Not that big a deal, but Andrews is assigned one of the leftover TODO
tags, just need to add the note on whats needed and remove his id from it
Thanks again
-Jake
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
