[
https://issues.apache.org/jira/browse/THRIFT-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964100#comment-13964100
]
ASF GitHub Bot commented on THRIFT-2456:
----------------------------------------
GitHub user adam-resdiary opened a pull request:
https://github.com/apache/thrift/pull/97
THRIFT-2456 Support async operations outside Silverlight
I altered TTransport to throw the NotSupportedExceptions to make it more
obvious what's going on if someone generates their client using the async
option, and then uses a transport that doesn't support it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adam-resdiary/thrift
THRIFT-2456-THttpClientAsync
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/97.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #97
----
commit 080b28eac31516ef9e3f988a87d890769f0751cd
Author: Adam Connelly <a...@resdiary.com>
Date: 2014-04-09T12:46:27Z
THRIFT-2456 Support async operations outside Silverlight
I altered TTransport to throw the NotSupportedExceptions to make it more
obvious what's going on if someone generates their client using the async
option, and then uses a transport that doesn't support it.
----
> THttpClient fails when using async support outside Silverlight
> --------------------------------------------------------------
>
> Key: THRIFT-2456
> URL: https://issues.apache.org/jira/browse/THRIFT-2456
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Affects Versions: 0.9.1
> Reporter: Adam Connelly
>
> THttpClient fails if you are using the standard .NET framework (i.e. not
> Silverlight), and you have generated your proxies using the async option. The
> error message is pretty unhelpful:
> "No request has been sent"
> This is caused by the BeginFlush method not being implemented outside
> Silverlight, which means that the request isn't sent.
> I think two changes should be made:
> * Either make BeginFlush / EndFlush abstract instead of virtual, or throw a
> NotSupportedException if the base implementation is called so that it's
> obvious what's going on.
> * Remove the conditional preprocessor directives that exclude the
> implementations of BeginFlush / EndFlush.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
