Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/100#issuecomment-40643771
  
    Thanks for the patch. I'm not so sure if introducing a number of 
dependencies plus another new test project by a coup de main is such a great 
idea, especially if we compare all those changes to the net size of the patch 
itself. Did you run the tests on all relevant platforms or only with Visual 
Studio? I'm just asking, because that's important.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to