[ 
https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973600#comment-13973600
 ] 

Vitali Lovich commented on THRIFT-2473:
---------------------------------------

Sorry.  It's in C++.  The __isset field is used inconsistently.  __set 
functions won't write that if the field is not-optional so the only time it 
gets set is if you deserialize it.

> _isset entries shouldn't be generated for non-optional fields
> -------------------------------------------------------------
>
>                 Key: THRIFT-2473
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2473
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler
>            Reporter: Vitali Lovich
>
> There's quite a bit of memory overhead (4 bytes per field) that's wasted on 
> every single type.  The __isset field is unused by the thrift type for fields 
> not annotated optional.
> Additionally, it causes confusion in program code since people never know 
> whether or not the __isset struct can be checked for a particular field or 
> not (e.g. for non-optional fields it would never get set normally unless you 
> deserialized it).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to