[ https://issues.apache.org/jira/browse/THRIFT-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Randy Abernethy updated THRIFT-2405: ------------------------------------ Attachment: 0001-repaired-node.js-multiplexing.patch This patch repairs the Node.js Multiplex server implementation. The full node.js make check now passes. As far as I can tell from walking the code history, the client side Multiplex code never worked for multiple servers. The node.js code base dumps several pages of jsHint warnings right now. The three files attached here are now jsHint clean, but there's still more to do. It would be great if we could require new JavaScript code to jsHint clean and include working tests prior to commit. > Node.js Multiplexer tests fail (silently) > ----------------------------------------- > > Key: THRIFT-2405 > URL: https://issues.apache.org/jira/browse/THRIFT-2405 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library > Affects Versions: 0.9.2 > Environment: all > Reporter: Randy Abernethy > Assignee: Randy Abernethy > Attachments: 0001-repaired-node.js-multiplexing.patch > > > Node.js Multiplexer tests fail silently. The client calls are made and the > server appears to report all of the proper input and return the proper > output. However, on the client side the results are never returned. -- This message was sent by Atlassian JIRA (v6.2#6252)