[ 
https://issues.apache.org/jira/browse/THRIFT-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977377#comment-13977377
 ] 

Aleksey Pesternikov commented on THRIFT-2491:
---------------------------------------------

Quote from [Effective Go|http://golang.org/doc/effective_go.html#package-names]:
{quote}
By convention, packages are given lower case, single-word names
{quote}
duh, CamelCase package names are wrong.
I was not able to find anything about file names though. However, there is no 
uppercase .go filenames in the standard library (only some Makefiles, .S and 
README)
to my taste, uppercase in go bear some special meaning (visibility) so using it 
when it is not relevant decreases readability.


> unable to import generated ThriftTest service
> ---------------------------------------------
>
>                 Key: THRIFT-2491
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2491
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Compiler
>            Reporter: Aleksey Pesternikov
>            Assignee: Jens Geyer
>            Priority: Minor
>
> IDL compiler uses service name converted from camel case to underscores as a 
> file name. service ThriftTest {} goes into thrift_test.go, which is not being 
> compiled since the file match *_test.go mask.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to