GitHub user apesternikov opened a pull request: https://github.com/apache/thrift/pull/109
THRIFT-2497 This change creates client and server for integration tests in test/go Also several improvements and fixes were implemented: additions: +test for client/server with several protocol/transport/ssl combinations +bin/testclient and bin/testserver +debug_transport, bin/testclient and bin/testserver use it with --debug_client_protocol and --debug_server_protocol respectively +command line flag --noinsane for test/cpp/TestClient. Go server does not support TestInsane, so cpp client is compatible with go server fixes: separate Listen() and AcceptLoop() instead of Serve() in SimpleServer for better testabiity if handler function returns any unknown exception, handler closes connection. TODO: simplify generated handler code noted but not fixed: listening socket is hanging open after server.Stop() for both ssl and non-ssl server. Not a critical issue, workaround in test using separate ports for every protocol/transport combination You can merge this pull request into a Git repository by running: $ git pull https://github.com/apesternikov/thrift go_integration Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/109.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #109 ---- commit f2e7186ca8d63f407dba0c56ee51afd6405926ba Author: Aleksey Pesternikov <a...@alekseys-mbp.att.net> Date: 2014-04-22T12:48:14Z add _ to generated filename if it ends with _test.go commit a6ed88196fbf4622a3b0261bbac0fe6b258bdd36 Author: Aleksey Pesternikov <a...@alekseys-mbp.att.net> Date: 2014-04-22T14:19:13Z use tcxx instead of tr1 in test/cpp commit d1848fa05f4baefc66eb405f4b1a8657bb2869bd Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local> Date: 2014-04-23T01:01:03Z Merge branch 'master' of https://github.com/apache/thrift into go_integration commit 04d22fef228d3f868b32a296a38f99ff52ee2142 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local> Date: 2014-04-25T00:34:24Z additions: test for client/server with several protocol/transport/ssl combinations bin/testclient and bin/testserver debug_transport fixes: separate Listen() and AcceptLoop() instead of Serve() in SimpleServer if handler function returns any unknown exception, handler closes connection commit ed88d57d977cffea9fac8f61143801f3097ef46c Author: Aleksey Pesternikov <a...@alekseys-mbp.att.net> Date: 2014-04-25T13:29:54Z Generate lowercase package name lowercased pkg name in thrift files underline() -> lowercase() commit 498a910c6c6753a4b1e3633eb5c9c82be33e8c7b Author: Aleksey Pesternikov <a...@alekseys-mbp.att.net> Date: 2014-04-25T13:32:26Z Merge branch 'master' into go_test_service_name commit 25792d7218a2c32ee3c2077f65ca7d0cea7f31f5 Author: Aleksey Pesternikov <a...@alekseys-mbp.att.net> Date: 2014-04-22T12:48:14Z add _ to generated filename if it ends with _test.go commit af994b415308a2e174d57a03675fc83d7cbd43d1 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local> Date: 2014-04-25T00:34:24Z additions: test for client/server with several protocol/transport/ssl combinations bin/testclient and bin/testserver debug_transport fixes: separate Listen() and AcceptLoop() instead of Serve() in SimpleServer if handler function returns any unknown exception, handler closes connection commit f22a777a5d5b4d93a8d7981e7aadc2c63919518a Author: Aleksey Pesternikov <a...@alekseys-mbp.att.net> Date: 2014-04-25T13:44:08Z Merge branch 'go_integration' of github.com:apesternikov/thrift into go_integration commit 49a33c8c80ea35f923ee9aa3577780fcf41fe840 Author: Aleksey Pesternikov <a...@alekseys-mbp.att.net> Date: 2014-04-25T13:49:05Z Merge branch 'master' into test_cpp_on_mac commit 81b402ec6301f6b132c9b346ad5481f55f0aff89 Author: Aleksey Pesternikov <a...@alekseys-mbp.att.net> Date: 2014-04-25T13:56:56Z operator < for ThriftTest commit cde312d940d12077274dd0ba677ca850b5b439a7 Author: Aleksey Pesternikov <a...@alekseys-mbp.att.net> Date: 2014-04-25T14:12:58Z minor formatting commit 0a693115c2c20a2a8375f3859ff7bed261e6c8da Author: Aleksey Pesternikov <a...@alekseys-mbp.att.net> Date: 2014-04-25T14:13:20Z Merge branch 'test_cpp_on_mac' into go_integration commit e06b5d24e8b6d429723a3c77a58c6ce903e1366a Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local> Date: 2014-04-25T15:19:20Z Merge branch 'go_test_service_name' into go_integration commit 42d577c9812a070060c773fcd0598e58e6d6ba61 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local> Date: 2014-04-25T15:39:57Z imported THRIFT-2491 lowercase package names commit 491ccf8b018c046c5ced72b1e19d9ac4ec48a6f5 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local> Date: 2014-04-25T15:51:53Z --noinsane flag for c++ TestClient. works with go server now for other default params commit 78db3c9a3a5742818a5de6e57f2fe9aed84919e5 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local> Date: 2014-04-25T16:03:23Z license ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---