[
https://issues.apache.org/jira/browse/THRIFT-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008322#comment-14008322
]
Jens Geyer edited comment on THRIFT-2544 at 5/25/14 11:57 AM:
--------------------------------------------------------------
Thanks for the patch.
A few remarks:
* the patch should be relative to the top of the source tree, instead of
{{lib/csharp/src/Transport}}
* I can't compile with WP7.x, I get several errors, see below. Do I need
additional references or does it just not work with WP7.x?
* I think it is better to split up the silverlight part from TSocket.cs into a
new file, maybe{{TSilverlightSocket.cs}}, instead of having two different
source codes in one file.
{code}
The type or namespace name 'SocketAsyncEventArgs' could not be found (are you
missing a using directive or an assembly reference?)
lib\csharp\src\Transport\TSocket.cs line 44 column 35
{code}
Thanks again,
JensG
was (Author: jensg):
Thanks for the patch.
A few remarks:
* the patch should be relative to the top of the source tree, instead of
{{lib/csharp/src/Transport}}
* I can't compile with WP7.x, I get several errors, see below. Do I need
additional references or does it just not work with WP7.x?
* I think it is better to split up the silverlight part from TSocket.cs into a
new {{TSilverlightrSocket.cs}} file, instead of having two different source
codes in one file.
{code}
The type or namespace name 'SocketAsyncEventArgs' could not be found (are you
missing a using directive or an assembly reference?)
lib\csharp\src\Transport\TSocket.cs line 44 column 35
{code}
Thanks again,
JensG
> Add support for socket transport for c# library when using Windows Phone
> projects
> ---------------------------------------------------------------------------------
>
> Key: THRIFT-2544
> URL: https://issues.apache.org/jira/browse/THRIFT-2544
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Library
> Affects Versions: 0.9.1, 0.9.2
> Environment: VS2013 with windows phone 8 development.
> Reporter: Matrix Ji
> Assignee: Jens Geyer
> Priority: Minor
> Labels: csharp, library, socket
> Fix For: 0.9.2
>
> Attachments: TSocket.cs, TSocket.cs.patch
>
>
> As TSocket.cs is not support WP's SDK (using TcpClient). Using tcp socket as
> the client's transport is not available.
> I hope using thrift-client with tcp socket and binary protocol in my new WP's
> application. I've already write a patch, hope this patch can be accepted in
> new release.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
