[
https://issues.apache.org/jira/browse/THRIFT-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029206#comment-14029206
]
Nobuaki Sukegawa commented on THRIFT-2520:
------------------------------------------
Is it about the travis error or are you having another problem with this patch ?
If you are referring to the travis build error, it's apparently caused by the
build system itself and the patch content is not related at all.
At the time of the pull request, there was no error nor test failure caused by
this patch AFAIK.
If you are having another issue, please show me the error log. I can work on
that and re-submit the patch against latest master if needed.
> cpp:cob_style generates incorrect .tcc file
> -------------------------------------------
>
> Key: THRIFT-2520
> URL: https://issues.apache.org/jira/browse/THRIFT-2520
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
> Affects Versions: 1.0
> Environment: Linux gcc
> Reporter: Nobuaki Sukegawa
>
> With cob_style switch, thrift compiler generates non-template method
> definitions into .tcc files, which results in link errors whenever you
> include a service header from multiple implementation files.
> Moving non-template methods to .cpp file resolves the problem.
> This problem is present only in recent master branch.
> pull request url:
> https://github.com/apache/thrift/pull/118
--
This message was sent by Atlassian JIRA
(v6.2#6252)
