Github user drobakowski commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/148#discussion_r14310051
  
    --- Diff: compiler/cpp/src/generate/t_erl_generator.cc ---
    @@ -510,7 +510,7 @@ string t_erl_generator::render_member_type(t_field * 
field) {
       } else if (type->is_struct() || type->is_xception()) {
         return "#" + uncapitalize(type->get_name()) + "{}";
       } else if (type->is_map()) {
    -    return "dict()";
    +    return "dict:dict()";
    --- End diff --
    
    Hi @cjimison good point but doesn't this break the compatibility with 
Erlang/OTP prior to 17.0? I think this could be done over an conditional macro 
defined in the rebar.config: ```{erl_opts, [ {platform_define, "^R", pre17} 
]}``` and some additions with ```-ifdef(pre17). ... -else. ... -endif.```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to