Github user uwydoc commented on the pull request:
https://github.com/apache/thrift/pull/86#issuecomment-47415698
This patch should work. Anyway, calling `TWinsockSingleton::create()` with
`ifdef` is what `TSocket::local_open` is doing for client winsock2
initialization.
As for the multiple-servers concern proposed by @henrique ,
`TWinsockSingleton` uses `boost::call_once` to ensure thread-safe one-time
initialization, so no worry.
As to the build error, after a simple glance at the build log:
```
...
$ sudo apt-get install -qq php5-dev php5-cli phpunit
Failed to fetch
http://security.ubuntu.com/ubuntu/pool/main/p/php5/php5-common_5.3.10-1ubuntu3.9_amd64.deb
404 Not Found [IP: 2001:67c:1360:8c01::19 80]
Failed to fetch
http://security.ubuntu.com/ubuntu/pool/main/p/php5/php5-cli_5.3.10-1ubuntu3.9_amd64.deb
404 Not Found [IP: 2001:67c:1360:8c01::19 80]
Failed to fetch
http://security.ubuntu.com/ubuntu/pool/main/p/php5/php-pear_5.3.10-1ubuntu3.9_all.deb
404 Not Found [IP: 2001:67c:1360:8c01::19 80]
Failed to fetch
http://security.ubuntu.com/ubuntu/pool/main/p/php5/php5-dev_5.3.10-1ubuntu3.9_amd64.deb
404 Not Found [IP: 2001:67c:1360:8c01::19 80]
E: Unable to fetch some archives, maybe run apt-get update or try with
--fix-missing?
[33;1mThe command "sudo apt-get install -qq php5-dev php5-cli phpunit"
failed and exited with 100 during before_install.[0m
Your build has been stopped.
```
it is clear that the error had resulted from some network error with the
build machine, not the patch itself.
So i think the patch owner @andrey-agenosov could submit again, or some
master can manually merge this pull request(or maybe fix the build error).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
