[
https://issues.apache.org/jira/browse/THRIFT-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046961#comment-14046961
]
Roger Meier commented on THRIFT-1857:
-------------------------------------
Thanks tbartelmess, great approach with python-six!
I've reviewed and tests pull request 144 and the test suite fails.
*make cross*
{noformat}
ERROR: testBackwards (__main__.AcceleratedBinaryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./SerializationTest.py", line 204, in testBackwards
obj = self._deserialize(VersioningTestV1, self._serialize(self.v2obj))
File "./SerializationTest.py", line 195, in _deserialize
ret.read(prot)
File "gen-py-default/ThriftTest/ttypes.py", line 1030, in read
fastbinary.decode_binary(self, iprot.trans, (self.__class__,
self.thrift_spec))
TypeError: expecting stringio input
ok======================================================================
{noformat}
Could you please check this and the review findings made by Eevee?
Thanks!
-roger
> Python 3.X Support
> ------------------
>
> Key: THRIFT-1857
> URL: https://issues.apache.org/jira/browse/THRIFT-1857
> Project: Thrift
> Issue Type: Improvement
> Components: Python - Compiler
> Affects Versions: 0.9
> Reporter: Avi Saranga
> Assignee: Roger Meier
>
> add support for python 3.x
--
This message was sent by Atlassian JIRA
(v6.2#6252)
