[
https://issues.apache.org/jira/browse/THRIFT-2594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052692#comment-14052692
]
Hudson commented on THRIFT-2594:
--------------------------------
FAILURE: Integrated in Thrift #1201 (See
[https://builds.apache.org/job/Thrift/1201/])
THRIFT-2594 JS Compiler: Single quotes are not being escaped in constants.
(roger: rev 45abf12f1353e982aea74ac9394438deb8a0a05e)
* compiler/cpp/src/generate/t_js_generator.cc
> JS Compiler: Single quotes are not being escaped in constants.
> ---------------------------------------------------------------
>
> Key: THRIFT-2594
> URL: https://issues.apache.org/jira/browse/THRIFT-2594
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Compiler
> Affects Versions: 0.9.1
> Environment: Windows 7
> Reporter: Thomas Lazar
> Assignee: Roger Meier
> Attachments:
> thrift-2594-add-single-quote-for-escaping-to-jsgenerator.patch
>
>
> If you define a constant containing single quotes in the thrift IDL the
> resulting JS constants are not properly escaped.
> Example:
> {code:title=test.thrift}
> const string test = "blah ' blub '' blahblahblubberblub''''''''"
> {code}
> gets compiled into
> {code:title=test_types.js}
> test = 'blah ' blub '' blahblahblubberblub''''''''';
> {code}
> instead it should result in
> {code:title=test_types.js - new}
> test = 'blah \' blub \'\' blahblahblubberblub\'\'\'\'\'\'\'\'';
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
