[ https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061667#comment-14061667 ]
ASF GitHub Bot commented on THRIFT-1357: ---------------------------------------- GitHub user talentdeficit opened a pull request: https://github.com/apache/thrift/pull/157 THRIFT-1357:Erlang Dependency breaks build client: erlang patch: talentdeficit (alisdair sullivan) integrate jsx json parser into thrift erlang client You can merge this pull request into a Git repository by running: $ git pull https://github.com/talentdeficit/thrift thrift-1357 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/157.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #157 ---- commit c9b21ef4baeb740a476a59eabdea760bb5dd7b9e Author: alisdair sullivan <alisdairsulli...@yahoo.ca> Date: 2014-07-15T04:50:43Z THRIFT-1357:Erlang Dependency breaks build client: erlang patch: talentdeficit (alisdair sullivan) integrate jsx json parser into thrift erlang client ---- > Erlang Dependency breaks build > ------------------------------ > > Key: THRIFT-1357 > URL: https://issues.apache.org/jira/browse/THRIFT-1357 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library > Affects Versions: 0.9 > Environment: Apache build Infrastructure based on Ubuntu lucid > {noformat} > ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1 > Erlang/OTP virtual machine and base applicat > ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1 > Erlang/OTP cryprographic modules > ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1 > Erlang/OTP development libraries and headers > ii erlang-eunit 1:13.b.3-dfsg-2ubuntu2.1 > Erlang/OTP module for unit testing > ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1 > Erlang/OTP modules for handling abstract Erl > ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1 > Erlang/OTP virtual machine and base applicat > ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1 > Erlang/OTP cryprographic modules > ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1 > Erlang/OTP development libraries and headers > ii erlang-eunit 1:13.b.3-dfsg-2ubuntu2.1 > Erlang/OTP module for unit testing > ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1 > Erlang/OTP modules for handling abstract Erl > {noformat} > Reporter: Roger Meier > Assignee: Jake Farrell > Fix For: 1.0 > > Attachments: > 0001-Fixed-thrift_json_protocol.erl-to-work-with-JSX-v0.9.patch, > 0001-updated-JSX-version.patch, thrift-1357.patch > > > THRIFT-1227 introduced JSON for erlang, > however the Ubuntu build infrastructur does not support this... > {noformat} > ./rebar get-deps > ==> erl (get-deps) > Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}} > Initialized empty Git repository in > /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/ > ==> nicefloats (get-deps) > ==> jsx (get-deps) > ./rebar compile > ==> nicefloats (compile) > Compiled src/nicefloats.erl > ==> jsx (compile) > ./include/jsx_common.hrl:34: type jsx_opt() undefined > ./include/jsx_common.hrl:66: type jsx_parser_result() undefined > ./include/jsx_common.hrl:82: type eep0018_array() undefined > ./include/jsx_common.hrl:82: type eep0018_object() undefined > ./include/jsx_common.hrl:84: type eep0018_term() undefined > ./include/jsx_common.hrl:85: type eep0018_key() undefined > ./include/jsx_common.hrl:85: type eep0018_term() undefined > ./include/jsx_common.hrl:91: type eep0018_string() undefined > ./include/jsx_common.hrl:92: type eep0018_number() undefined > ./include/jsx_common.hrl:100: type encoder_opt() undefined > ./include/jsx_common.hrl:109: type decoder_opt() undefined > ./include/jsx_common.hrl:117: type verify_opt() undefined > ./include/jsx_common.hrl:123: type format_opt() undefined > make[3]: *** [all] Error 1 > {noformat} -- This message was sent by Atlassian JIRA (v6.2#6252)