[ https://issues.apache.org/jira/browse/THRIFT-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068344#comment-14068344 ]
ASF GitHub Bot commented on THRIFT-2633: ---------------------------------------- GitHub user talentdeficit opened a pull request: https://github.com/apache/thrift/pull/160 THRIFT-2633 remove 'this is a dummy struct' structs from generated erlang client: erlang patch: talentdeficit (alisdair sullivan) removes dummy struct info clauses from generated code and replaces them with error that matches other undefined structs You can merge this pull request into a Git repository by running: $ git pull https://github.com/talentdeficit/thrift thrift-2633 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/160.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #160 ---- commit 204df8fe30d711a75af0d3315fdae2082845632b Author: alisdair sullivan <alisdairsulli...@yahoo.ca> Date: 2014-07-21T09:24:40Z THRIFT-2633 remove 'this is a dummy struct' structs from generated erlang client: erlang patch: talentdeficit (alisdair sullivan) removes dummy struct info clauses from generated code and replaces them with error that matches other undefined structs ---- > remove 'this is a dummy struct' structs from generated erlang > ------------------------------------------------------------- > > Key: THRIFT-2633 > URL: https://issues.apache.org/jira/browse/THRIFT-2633 > Project: Thrift > Issue Type: Improvement > Components: Erlang - Compiler > Reporter: alisdair sullivan > Priority: Minor > Labels: erlang > > the erlang backend adds 'this is a dummy struct' struct_info/1 (and > struct_info_ext/1) clause to generated files which is probably incorrect > behavior. it should probably instead be a function clause that catches all > undefined structs and returns either 'undefined' or throws a > 'function_clause' error. i've supplied a patch that does the latter (as that > is the current behavior if you call struct_info/1 or struct_info_ext/1 with > an undefined struct name) -- This message was sent by Atlassian JIRA (v6.2#6252)