[ https://issues.apache.org/jira/browse/THRIFT-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074379#comment-14074379 ]
Jake Farrell commented on THRIFT-2637: -------------------------------------- hi [~thomaslee], I have not cut 0.9.2-RC1 yet. Why would we want to have the options split? I would be in favor of having if fullcamel is enabled then the service methods should become camel case as well and not add a second option for it > "java:fullcamel_service_methods" option to automatically camel-case Java > service methods > ---------------------------------------------------------------------------------------- > > Key: THRIFT-2637 > URL: https://issues.apache.org/jira/browse/THRIFT-2637 > Project: Thrift > Issue Type: New Feature > Components: Java - Compiler > Affects Versions: 0.9.2 > Reporter: Tom Lee > Priority: Minor > Attachments: fullcamel_service_methods.patch > > > [~roger.meier] I hope this isn't too late for the 0.9.2 RC, but it occurred > to me recently that the java:fullcamel feature which landed in THRIFT-2469 > was only half the picture for Java developers consuming Thrift services from > other languages. Specifically, accessors would look as you might expect using > java:fullcamel, but service methods will remain untouched. > This patch will modify the compiler to add a new option -- > java:fullcamel_service_methods -- which will cause service methods to be > exposed as camelCase methods. For example: a service method called > foo_bar_baz becomes fooBarBaz at the source level, while maintaining > protocol-level compatibility. > I pondered simply making this the default behavior of the java:fullcamel > option & simply omitting the new option -- easy enough change to make if > those semantics are preferred. -- This message was sent by Atlassian JIRA (v6.2#6252)