[
https://issues.apache.org/jira/browse/THRIFT-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075417#comment-14075417
]
ASF GitHub Bot commented on THRIFT-585:
---------------------------------------
GitHub user jamesbroadhead opened a pull request:
https://github.com/apache/thrift/pull/165
THRIFT-585 Wrap py:twisted calls in maybeDeferred
This avoids synchronous exceptions from the client libraries.
This is an update of the patch posted to:
https://issues.apache.org/jira/browse/THRIFT-585
Patch: Mattias de Zalenski, James Broadhead
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jamesbroadhead/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #165
----
commit 1f5c259be39a4a9cbb2bab0a7a786116bc0a58f1
Author: James Broadhead <jbroadh...@twitter.com>
Date: 2014-07-26T12:00:10Z
THRIFT-585 Wrap py:twisted calls in maybeDeferred
This avoids synchronous exceptions from the client libraries.
Patch: Mattias de Zalenski, James Broadhead
----
> exceptions in the autogenerated send_METHOD functions are not propagated
> (Twisted)
> ----------------------------------------------------------------------------------
>
> Key: THRIFT-585
> URL: https://issues.apache.org/jira/browse/THRIFT-585
> Project: Thrift
> Issue Type: Bug
> Components: Python - Compiler, Python - Library
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: 585-handle-send-exceptions.patch,
> ASF.LICENSE.NOT.GRANTED--t_py_generator.cc
>
>
> If an error occurs in the autogenerated send_METHOD functions, the returned
> deferred is not notified and the caller can't manage the error.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
