[
https://issues.apache.org/jira/browse/THRIFT-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087195#comment-14087195
]
ASF GitHub Bot commented on THRIFT-2648:
----------------------------------------
GitHub user talentdeficit opened a pull request:
https://github.com/apache/thrift/pull/174
THRIFT-2648 cleanup erlang lib
client: erlang
patch: alisdair sullivan (alisdairsulli...@yahoo.ca)
moves tests for the thrift compiler generation of files to /test/erl,
properly removes artifacts from test
suite runs, adds module listing to .app.src for better behaviour when using
erlang tools like relx and
rebar and modifies .gitignore to not ignore relevant erlang test components
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/talentdeficit/thrift thrift-2648
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #174
----
commit b86402ad1b20b88b5800740373b72f023e247608
Author: alisdair sullivan <alisdairsulli...@yahoo.ca>
Date: 2014-08-06T02:54:57Z
THRIFT-2648 cleanup erlang lib
client: erlang
patch: alisdair sullivan (alisdairsulli...@yahoo.ca)
moves tests for the thrift compiler generation of files to /test/erl,
properly removes artifacts from test
suite runs, adds module listing to .app.src for better behaviour when using
erlang tools like relx and
rebar and modifies .gitignore to not ignore relevant erlang test components
----
> cleanup erlang lib
> ------------------
>
> Key: THRIFT-2648
> URL: https://issues.apache.org/jira/browse/THRIFT-2648
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Compiler, Erlang - Library
> Reporter: alisdair sullivan
> Priority: Minor
> Labels: erlang
>
> this patch aims to clean up the erlang component of thrift. it does the
> following:
> * moves tests that are specifically for files generated by the compiler to
> /test/erl
> * modifies the project .gitignore to not ignore relevant files
> * modifies makefiles to properly remove artifacts when clean target is run
--
This message was sent by Atlassian JIRA
(v6.2#6252)
