[
https://issues.apache.org/jira/browse/THRIFT-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095653#comment-14095653
]
ASF GitHub Bot commented on THRIFT-2665:
----------------------------------------
GitHub user virtuald opened a pull request:
https://github.com/apache/thrift/pull/189
THRIFT-2665: Debug statements are unnecessary and should be removed
https://issues.apache.org/jira/browse/THRIFT-2665
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/virtuald/thrift mainline-remove-debug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #189
----
commit 67ec7e5cfe3ada7904db1439e52f2375ac72f985
Author: Dustin Spicuzza <dus...@virtualroadside.com>
Date: 2014-08-12T22:02:53Z
Debug statements are unnecessary and should be removed
----
> tornado library debug messages are too verbose
> ----------------------------------------------
>
> Key: THRIFT-2665
> URL: https://issues.apache.org/jira/browse/THRIFT-2665
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Affects Versions: 0.9.1
> Reporter: Dustin Spicuzza
>
> In TTornado.py, It generates a debug message each time a new message comes
> in. The other python bindings do not have the same behavior, so it doesn't
> make sense to keep this debug code in the bindings. Presumably those log
> messages are only useful for thrift developers or someone debugging thrift
> itself.
> Especially considering that it's logging to the root logger (see
> THRIFT-2663), it makes it really difficult to ignore these messages.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
