[
https://issues.apache.org/jira/browse/THRIFT-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124451#comment-14124451
]
ASF GitHub Bot commented on THRIFT-2692:
----------------------------------------
GitHub user hcorg opened a pull request:
https://github.com/apache/thrift/pull/209
THRIFT-2692 compiler refactor
https://issues.apache.org/jira/browse/THRIFT-2692
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hcorg/thrift THRIFT-2692_compiler_refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/209.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #209
----
commit 2346e5c516faa8b3711d39f24f372e353e0586b0
Author: Konrad Grochowski <hc...@minions.org.pl>
Date: 2014-09-05T10:58:28Z
libgenerate extracted from thrift executable so compiler specific unit
tests can be added
commit 7f033acde54db10ca5414184263034399b7a1e9f
Author: Konrad Grochowski <hc...@minions.org.pl>
Date: 2014-09-05T14:46:45Z
make check fixed - EnumTest compiles
commit f8af2c8857a1d1f0265aaa057652179d337f0eae
Author: Konrad Grochowski <hc...@minions.org.pl>
Date: 2014-09-06T12:20:43Z
compiler: IndentKeeper extracted from t_generator
* tests added for IndentKeeper
* t_generator movd a little bit towards meeting SRP
* IndentKeeper can be reused by lower level generator
(like MethodGenerator)
----
> Allow unit testing of compiler parts
> ------------------------------------
>
> Key: THRIFT-2692
> URL: https://issues.apache.org/jira/browse/THRIFT-2692
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process, Compiler (General)
> Reporter: Konrad Grochowski
>
> Currently whole compiler builds as single executable. To allow unit testing
> compiler has to be split into libraries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
